Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #10761 follow ups #10825

Merged
merged 3 commits into from Mar 21, 2024
Merged

PR #10761 follow ups #10825

merged 3 commits into from Mar 21, 2024

Commits on Mar 21, 2024

  1. Fix wrong test assumptions 

    PR #10761 added a new CLI command to list Web MQTT connections.
That new CLI command relies on feature flag delete_ra_cluster_mqtt_node
being enabled.

This commit ensures exactly this condition.
    @ansd
    ansd committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    8233db0 View commit details
    Browse the repository at this point in the history

  2. Move macro to the correct Erlang app 

    The Web MQTT link is not used in the rabbitmq_mqtt Erlang app.
This link is only used in the rabbitmq_web_mqtt Erlang app.
Hence, move the link to the correct Erlang app.
    @ansd
    ansd committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    4b95745 View commit details
    Browse the repository at this point in the history

  3. Avoid rabbit_ct_helpers:is_mixed_versions/0 

    Fixes #10761 (comment) :
"Could you please check a real condition that the old
version can't be used as part of this test?
is_mixed_versions() will still return true in 10 years
when testing RabbitMQ 21.x against 22.x. This function should
almost never be used."
    @ansd
    ansd committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    3fd96b5 View commit details
    Browse the repository at this point in the history