Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consumers per channel limit #10749

Closed
wants to merge 2 commits into from
Closed

Conversation

illotum
Copy link
Collaborator

@illotum illotum commented Mar 14, 2024

Proposed Changes

This adds a simple per channel limit to the number of consumers. Addresses the raised recently issue with consumer leaks leading to crashes.

It does affect "reply-to" consumers. But doesn't run in rabbit_channel:handle_consuming_queue_down_or_eol. Open to suggestions regarding these cases.

Note that crossing the limit crashes the connection. Same behavior as channel limit, so I figured it's acceptable.

Additionally, fixes a bit of docs and tests for channel_max_per_node.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

deps/rabbit/src/rabbit_channel.erl Outdated Show resolved Hide resolved
deps/rabbit/priv/schema/rabbit.schema Outdated Show resolved Hide resolved
@illotum illotum marked this pull request as ready for review March 15, 2024 17:56
@illotum illotum force-pushed the consumers-limit branch 2 times, most recently from 0b57d2c to 0edd4a1 Compare March 15, 2024 21:34
@michaelklishin
Copy link
Member

Merged with a couple of minor changes in #10754.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants