Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This adds a simple per channel limit to the number of consumers. Addresses the raised recently issue with consumer leaks leading to crashes.
It does affect "reply-to" consumers. But doesn't run in
rabbit_channel:handle_consuming_queue_down_or_eol
. Open to suggestions regarding these cases.Note that crossing the limit crashes the connection. Same behavior as channel limit, so I figured it's acceptable.
Additionally, fixes a bit of docs and tests for
channel_max_per_node
.Types of Changes
Checklist
CONTRIBUTING.md
document