Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #10345. Add prometheus_rabbitmq_federation_collector. #10721

Merged
merged 2 commits into from Mar 15, 2024

Conversation

ikavgo
Copy link
Contributor

@ikavgo ikavgo commented Mar 12, 2024

rabbitmq_federation_links gauge metric with status lable.

Proposed Changes

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

TODO:

@ikavgo ikavgo marked this pull request as draft March 12, 2024 13:21
@mergify mergify bot added the bazel label Mar 12, 2024
@ikavgo ikavgo force-pushed the ik-10345-prometheus-federation-collector branch 2 times, most recently from d94258f to 63b656f Compare March 13, 2024 11:50
@ikavgo ikavgo changed the title Close #10345. Add promtheus_rabbitmq_federation_collector. Close #10345. Add prometheus_rabbitmq_federation_collector. Mar 13, 2024
@ikavgo ikavgo requested a review from pjk25 March 13, 2024 11:51
@ikavgo ikavgo marked this pull request as ready for review March 13, 2024 11:52
@ikavgo ikavgo force-pushed the ik-10345-prometheus-federation-collector branch 2 times, most recently from ad2cbc9 to f68119f Compare March 13, 2024 18:55
deadtrickster and others added 2 commits March 14, 2024 09:29
rabbitmq_federation_links gauge metric with status lable.
Since gazelle goes away in rules_erlang 4, we just workaround this
with a '#keep' directive
@ikavgo ikavgo force-pushed the ik-10345-prometheus-federation-collector branch from f68119f to e04e455 Compare March 14, 2024 08:29
@michaelklishin michaelklishin merged commit de6cff6 into main Mar 15, 2024
17 checks passed
@michaelklishin michaelklishin deleted the ik-10345-prometheus-federation-collector branch March 15, 2024 01:50
michaelklishin added a commit that referenced this pull request Mar 15, 2024
Close #10345. Add prometheus_rabbitmq_federation_collector. (backport #10721)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants