Prevent not_found on list web mqtt connections

[LoisSotoLopez]

Proposed Changes

Fixes #9302

As described in the discussion list MQTT connection gives a :not_found when listing Web MQTT connections so we've provided a separated command for listing web MQTT connections.

Types of Changes

• Bug fix (non-breaking change which fixes issue #NNNN)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause an observable behavior change in existing systems)
• Documentation improvements (corrections, new content, etc)
• Cosmetic change (whitespace, formatting, etc)
• Build system and/or CI

Checklist

You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code._

• I have read the CONTRIBUTING.md document
• I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
• I have added tests that prove my fix is effective or that my feature works
• All tests pass locally with my changes
• If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
• If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Regarding tests for this feature, we were not sure whether to provide them under the rabbitmq_mqtt plugin or under rabbitmq_web_mqtt since there are some tests/utilities for testing Web MQTT connections under deps/rabbitmq_mqtt. Any hints on where said tests should get placed?

[pivotal-cla]

@LoisSotoLopez Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@LoisSotoLopez Thank you for signing the Contributor License Agreement!

[LoisSotoLopez]

This PR is now ready for revision.

[LoisSotoLopez]

Citing the question on Further Comments to be discussed here.

Regarding tests for this feature, we were not sure whether to provide them under the rabbitmq_mqtt plugin or under rabbitmq_web_mqtt since there are some tests/utilities for testing Web MQTT connections under deps/rabbitmq_mqtt. Any hints on where said tests should get placed?

[michaelklishin]

@LoisSotoLopez everything related to Web MQTT can be moved to rabbitmq_web_mqtt.

[michaelklishin]

@LoisSotoLopez do you consider this PR to be done or is there still more work to do?

[LoisSotoLopez]

@michaelklishin

@LoisSotoLopez do you consider this PR to be done or is there still more work to do?

From the "@LoisSotoLopez everything related to Web MQTT can be moved to rabbitmq_web_mqtt." response I understood it would be okay to provide some tests under deps/rabbitmq_web_mqtt so I'm working on them. I'll mention you after pushing those tests. 👍

[LoisSotoLopez]

@michaelklishin tests ready for revision

[michaelklishin]

This PR currently does not build with Bazel for two reasons:

1. The new test suite is missing a definition for the new suite
2. bazel run gazelle needs to be run

I'm looking at it.

[michaelklishin]

Some of the failures may not be related but the following must be added to BUILD.bazel in the Web MQTT plugin:

rabbitmq_integration_suite(
    name = "command_SUITE",
)

We'll look into other Bazel-related things. For now, I can at least continue using Make.

[LoisSotoLopez]

Closed by #10778