Skip to content

Commit

Permalink
Fix wrong test assumptions
Browse files Browse the repository at this point in the history
PR #10761 added a new CLI command to list Web MQTT connections.
That new CLI command relies on feature flag delete_ra_cluster_mqtt_node
being enabled.

This commit ensures exactly this condition.

(cherry picked from commit 8233db0)
  • Loading branch information
ansd authored and mergify[bot] committed Mar 21, 2024
1 parent c8dd649 commit 631df5c
Showing 1 changed file with 2 additions and 17 deletions.
19 changes: 2 additions & 17 deletions deps/rabbitmq_mqtt/test/command_SUITE.erl
Expand Up @@ -56,24 +56,9 @@ end_per_suite(Config) ->
init_per_group(unit, Config) ->
Config;
init_per_group(Group, Config) ->
ok = rabbit_ct_broker_helpers:enable_feature_flag(Config, delete_ra_cluster_mqtt_node),
Config1 = rabbit_ct_helpers:set_config(Config, {mqtt_version, Group}),
case Group of
v4 ->
AllApps = rabbit_ct_broker_helpers:rpc_all(Config1, application, loaded_applications, []),
AllAppNames = lists:map(fun (AppList) ->
lists:map(fun ({Name, _, _}) -> Name end, AppList)
end, AllApps),
case lists:all(fun (NodeApps) ->
lists:member(rabbit_web_mqtt_app, NodeApps)
end, AllAppNames) of
true ->
Config1;
false ->
{skip, "rabbit_web_mqtt_app not available on all nodes"}
end;
v5 ->
util:maybe_skip_v5(Config1)
end.
util:maybe_skip_v5(Config1).

end_per_group(_, Config) ->
Config.
Expand Down

0 comments on commit 631df5c

Please sign in to comment.