Skip to content

Commit

Permalink
* Remove two TODOs because resolving them resulted in too many other …
Browse files Browse the repository at this point in the history
…errors
  • Loading branch information
lukebakken committed May 9, 2024
1 parent 5adb0a8 commit b79c261
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions projects/RabbitMQ.Client/client/impl/ChannelBase.cs
Expand Up @@ -505,13 +505,19 @@ private void OnChannelShutdown(ShutdownEventArgs reason)
_flowControlBlock.Set();
}

// TODO async
/*
* Note:
* Attempting to make this method async, with the resulting fallout,
* resulted in many flaky test results, especially around disposing
* Channels/Connections
*
* Aborted PR: https://github.com/rabbitmq/rabbitmq-dotnet-client/pull/1551
*/
private void OnSessionShutdown(object sender, ShutdownEventArgs reason)
{
ConsumerDispatcher.Quiesce();
SetCloseReason(reason);
OnChannelShutdown(reason);
// TODO async
ConsumerDispatcher.Shutdown(reason);
}

Expand Down

0 comments on commit b79c261

Please sign in to comment.