Implement hierarchy helper functions #190
Conversation
| import com.ramcosta.destinations.sample.destinations.TypedDestination | ||
| import java.io.InvalidObjectException | ||
|
|
||
| inline fun <reified T> Any.asRoute(): Route? { |
There was a problem hiding this comment.
Seems to me like an unnecessary pollution of the Any class. Could we make the type more specific or move the function to some other place instead of extending Any class?
There was a problem hiding this comment.
I thought I deleted this file actually 🤔 guess I forgot it when I pushed. I'll correct this today! Thanks!
There was a problem hiding this comment.
@Nek-12 I can confirm this file was deleted in the final commit. The initial idea with this function was to convert a NavGraphSpec, DestinationSpec or String? into a Route? which as you can see by the types, have very little in common 😉 But nonetheless, thank you for pointing it out! I'll make sure to be more cautious in the future!
|
Hello @raamcosta, not sure how merging PR's work for you so sorry for tagging you for no reason if it's unnecessary.. This PR feels up to standard for me in terms of its contents, feel free to approve or reject it! There's probably a more elegant way of doing the same thing but hey, I'm learning the internals of your library (which I find really interesting by the way!) :) Thanks in advance |
Of course! Thank you so much for this PR 🙏 Thank you also for checking the code and liking it. There is quite a bit of messy parts in there that I wish I had time to clean up 😅 |
|
@MaxMichel2 sorry I still haven’t merged this, it is not forgotten. |
raamcosta
force-pushed
the
main
branch
6 times, most recently
from
5185a19
to
7b51caa
Compare
Adds the #186 enhancement