Rework calcAxisLogScale(). Fixes endless loop. #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have checked this PR and found no issues. This PR is marked as WIP. Are planning to add more commits? Otherwise I will merge it. |
|
Works fine for me too. Nothing to add. You can merge it. |
|
Thanks for the contribution! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with logarithmic axis.
If all Y-values in the dataset are close to 1, like 1 +/- 1e-6, Qucs-s enters endless loop with increasing memory allocation.
The attached schematic can be used to reproduce the issue and test the patch.
To reproduce the issue change the left axis to logarithmic. Make sure you can easily kill Qucs-s.
Tested with ngspice.
test-log-scale.sch.txt