Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Enable self-sizing for component in SwiftUI #60

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ra1028
Copy link
Owner

@ra1028 ra1028 commented Oct 23, 2019

TODO

  • Enable self-sizing
  • Add ReferenceSizeComponentWrapper.
  • Remove Component.intrinsicContentSize(for:) added in RC5
  • Add or remove tests.
  • Update README and docs

Checklist

Description

SwiftUI can't support self-sizing, but we can one approach that calculating the size of content at the appearing event with GeometryReader in background.

Related Issue

N/A

Motivation and Context

Further clear and intuitive API for the Carbon component in the SwiftUI.

Impact on Existing Code

Remove Component.intrinsicContentSize(for:) added in RC5

Screenshots (if appropriate)

struct KyotoTop_Previews: PreviewProvider {
    static var previews: some View {
        KyotoTop()
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant