Fix Issue #1961: tidy unzip directory

[burnsal]

Fix for issue #1961 to allow use_zip to successfully unzip file with different directory structure

[jennybc]

Can you create a small .zip file that displays the behaviour you're targetting? And add it as a test fixture, similar to yo-loose-regular.zip and the like, all explained here https://github.com/r-lib/usethis/tree/main/tests/testthat/ref.

Then you can add a new test for your scenario, along these lines:

usethis/tests/testthat/test-course.R

Lines 86 to 107 in fdb4a72

	test_that("tidy_unzip() deals with loose parts, reports unpack destination", {
	tmp <- file_temp(ext = ".zip")
	fs::file_copy(test_file("yo-loose-regular.zip"), tmp)
	dest <- tidy_unzip(tmp)
	loose_regular_files <- fs::path_file(fs::dir_ls(dest, recurse = TRUE))
	fs::dir_delete(dest)
	tmp <- file_temp(ext = ".zip")
	fs::file_copy(test_file("yo-loose-dropbox.zip"), tmp)
	dest <- tidy_unzip(tmp)
	loose_dropbox_files <- fs::path_file(fs::dir_ls(dest, recurse = TRUE))
	fs::dir_delete(dest)
	tmp <- file_temp(ext = ".zip")
	fs::file_copy(test_file("yo-not-loose.zip"), tmp)
	dest <- tidy_unzip(tmp)
	not_loose_files <- fs::path_file(fs::dir_ls(dest, recurse = TRUE))
	fs::dir_delete(dest)
	expect_identical(loose_regular_files, loose_dropbox_files)
	expect_identical(loose_dropbox_files, not_loose_files)
	})

You can put that in a new test, i.e. a new test_that() block inside test-course.R.

[burnsal]

Test fixture added. I was not able to find the test_file function, but the test works for me if I change that command to point to the test file in the testthat/ref folder, the test script runs smoothly.

[burnsal]

@jennybc Sorry for the delay, it took me a while to get back to this! I have resolved typo on previous request and updated test to be compatible with current main branch.