Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added vignette on Python and flair #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ttimbers
Copy link

@ttimbers ttimbers commented Jul 30, 2020

@kbodwin - I have created this PR to add a vignette on Python and flair. However, it depends on Python, {reticulate}, and pandas. So if you incorporate this PR, you will need to install those things to rebuild your site with {pkgdown}...

Also, I am a little stuck on using pkgdown::build_site as although I can use the knit button to render the vignette, when I run pkgdown::build_site it cannot find Python on my machine. Which is bizarre as I said above I can render it via the knit button which uses both Python and reticulate. I am going to open an issue in the {pkgdown} repo to find out how to deal with this... Fixed!

@ttimbers
Copy link
Author

I think the build is failing on TravisCI because of the missing dependencies I mentioned above. Two possible solutions:

  1. Add these dependencies to the .travis.yml file

  2. Add the vignette to the .Rbuildignore and not rebuild it each time you run R CMD build

I am not well versed in TravisCI (I have more experience with GitHub actions...) so I am not sure how much help I will be with suggestion # 1 (I know it's possible, I could probably do it, but is it worth the effort for the vignette is the question).

@kbodwin kbodwin force-pushed the master branch 2 times, most recently from 20076b7 to 4664b3c Compare February 10, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant