Add kid header #184
Open
Add kid header #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-w
suggested changes
Feb 11, 2021
| return token.SignedString(key) | ||
| } | ||
|
|
||
| func (h *Handler) GetToken(r *http.Request) (userInfo model.UserInfo, valid bool) { | ||
| func (h *Handler) GetToken(r *http.Request) (userInfo model.UserInfo, headers map[string]interface{}, valid bool) { |
There was a problem hiding this comment.
Don't introduce return values for testing purposes.
| True(t, valid) | ||
| Equal(t, input, userInfo) | ||
| } | ||
|
|
||
| func TestHandler_getToken_Key_ID(t *testing.T) { |
There was a problem hiding this comment.
The Name of the Test does not describe the tested feature. It should state that the kid value is stored in the jwt header if a token is generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #160