FLiMESolve #2186
Open
FLiMESolve #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reconstructed FLiMESolve and FLiMESolver to play more nicely with other QuTiP functions. Wrote FLiMESolver into the correlation tab, but had to add taulist as an input into the _make_solver function.
Trying to rework the time list stuff in FlimeSolve/er to work better with QuTiP. Namely, autogeneration of the time list to create the rate matrix & trying to avoid time list in solver.run so I don't have to do anything kludgey to get the modes in an expedient way
Rewrote the mode table in solver.run() to be found in a slightly slower, but much more generalized fashion
Figured out how to do Expectation operators with my construction of the solvers, and I added a constraint the to the available frequencies in the relaxed secular approx. based on the Nyquist theorem.
Floquet beta
Added flimesolve to dynamics-floquet documentation, and added floquet_ex4 as an example usage (identical to floquet_ex3 with exception of use of flimesolve instead of fmmesolve) Added towncrier changelog...I think
…to qutip-5.0.X
Got rid of a few commented lines that were not useful
Deleted folder of scripts I'm using to write a paper about this solver
I fixed linting, extra spacing, and blank line issues. Moved all new functions to flimesolve.py. Replaced scipy functions with Numpy equivalents. Fixed issues in correlation.py by updating to my most current version, which should just introduce flimesolve.py as an additional solver.
Commented out a [0] in line 91 for some reason. I uncommented it now to bring it better in line with correlation.py
Fixing code format
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Used built-in autoformat in Spyder and then pycodestyle afterwards to fix code format to PEP8 guidelines.
…to qutip-5.0.X
Made a few changes caught by CodeClimate on Github
|
@Ericgig Pushed all the changes, this time. |
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Added flimesolve import
Ericgig
reviewed
Apr 30, 2024
Ericgig
reviewed
Apr 30, 2024
Ericgig
reviewed
Apr 30, 2024
Updates test_flimesolve.py to include a test with nonzero time_sense value and to include a test for the correlation function. Also fixed some typos/added a few words in places.
|
@Ericgig I fixed the typos you mentioned and added a test in for nonzero timesense values and for the correlation functions. I also fixed the typo you mentioned and added a short descriptor for FLiMESolve above the "parameters" in documentation. |
Ericgig
reviewed
May 3, 2024
Fixed some bad documentation on c_ops. Also added a bit more about which method is used depending on time_sense values.
Updated Correlation test to be much cleaner, more streamlined. Also removed a bunch of unnecessary numpy functions and replaced with QuTiP functions where applicable.
Ericgig
reviewed
May 3, 2024
Updated Flimesolve with a steady state solver. This uses the rate matrix as an analogue for the Monodromy matrix to find the steady state of the system in the full secular approximation. Not sure if adding in more time-dependence (if possible) would do anything, as I think that would just cause the solution to orbit/rotate around the time independent result.
Attempting to fix the build error.
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
Co-authored-by: Eric Giguère <eric.giguere@calculquebec.ca>
|
@Ericgig Hey Eric, added your changes to the test, fixed the documentation error as well. I also added a steady state solver, would you want me to make a test for that? |
Ericgig
reviewed
May 6, 2024
Removed the steady state solver to add it in as a separate PR later.
Fixed some issues in the correlation function test
Ericgig
reviewed
May 13, 2024
There was a problem hiding this comment.
I discussed with @hodgestar and we want citation(s) to paper(s) where the equations are explained added before merging.
Fixed an fftshift causing state decay to move backwards. This was already fixed and made its way back in somehow. I...don't know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added FLiMESolve. Changed head to master branch after merging QuTiP 5.0.X to master.
Old PR here: #2140