-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve plotting and add pulse_mode #1446
Improve plotting and add pulse_mode #1446
Conversation
b4b05c8
to
e501054
Compare
Use Scipy interpolation for plotting
c97bc44
to
0a1dc93
Compare
A wrapper for spline_kind, using discrete and continuous instead of steup_func and cubic.
In QuTiP capital letter are used for operators, like H. Due to historical reason, N is used in qip for number of qubits. We would like to replace it with num_qubits in qutip_qip. Start from this wrapper.
0a1dc93
to
c0a565c
Compare
if i == 0 and j == 0 and title is not None: | ||
ax.set_title(title) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could remain outside the loop, but probably just personal preference:
for i, label_group in ...:
[plotting stuff]
if axis and title:
axis[0].set_title(title)
Is there a reason it only sets the title for one axis? I'm sure there is, just I don't see it immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed this is on purpose, n axes are arranged in a column and they need only one title. It can also be down with fig
I guess but I think set the title for axis[0]
is safer for the position of the title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a failing test for mesolve coeff, which I don't think is relevant to this PR. |
I never saw the test failure in |
Description
pulse_mode
as a wrapper for spline_kind, for discrete and continuous pulses. They are more friendly names for experimentalists.num_qubits
as a replacement forN
. In QuTiP capital letter are used for operators, likeH
for Hamiltonian. Due to historical reason,N
is used inqip
for the number of qubits. We would like to replace it withnum_qubits
inqutip_qip
. Start from this wrapper and promoting the usage of this in notebooks guide.Changelog
Minor