Qutip simulator #1438
Closed
Qutip simulator #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler structure is updated to prepare for the use of scheduling. No functionality is changed according to this PR, only the internal interfaces.
fix the float point inaccuracy in pulse model
decompose -> compiler
Add a dictionary that map the name of each pulse to its indices. It makes the definition of compiler more readable.
Global phase was used in the old version for computing the analytical result. But in mesolve simulation it does not make sense.
Make the compiler support continous pulse and use cubic spline
The list of pulses were not correctly passed to the method.
The representation of noisy dynamic is changed. During the processing of noise, the number of Pulse object in `pulses` passed by the Processor remain unchanged. Instead, the systematic noise (pulse independent noise) is store in one dummy `Pulse` object with no ideal control pulse.
Some tests were not caught by pytest. There was a bug in calling mcsolve.
2021/02/03 first commit. from lenovo
The interpolation _fill_coeff was wrong if the tlist is longer than the required one. Here scipy interpolation function is used. It can be used to replace the _fill_coeff later. With a more thorough test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to QuTiP! Please make sure you have finished the following tasks before opening the PR.
You can use pycodestyle to check your code automatically
Delete this checklist after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work and keep this checklist in the PR description.
Description
Describe here the proposed change.
Related issues or PRs
Please mention the related issues or PRs here. If the PR fixes an issue, use the keyword fix/fixes/fixed followed by the issue id, e.g. fix #1184
Changelog
Give a short description of the PR in a few words. This will be shown in the QuTiP change log after the PR gets merged.
For example:
Fixed error checking for null matrix in essolve.
Added option for specifying resolution in Bloch.save function.