Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added improved sampling example to nmmcsolve notebook #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pmenczel
Copy link
Member

@pmenczel pmenczel commented May 7, 2024

Added a small example for the improved sampling option to the nm_mcsolve notebook. This option was disabled for nm_mcsolve until PR 2369.

The advantage of the improved sampling is not super apparent here tbh, since the frequency of no-jump trajectories are low in the examples here. (But creating a completely new example just for this would be a bit much.)

Copy link
Member

@Ericgig Ericgig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the graph produced and there is a visible difference between improved sampling or not and no trajectories without collapse.
Is that just bad luck?

@pmenczel
Copy link
Member Author

pmenczel commented May 8, 2024

Yes unfortunately, the difference between improved sampling or not is not really visible because of too much randomness. In the output of the Counter, one can see that with the improved sampling, only one trajectory with zero jumps is generated.

The difference should be more visible in an example where most of the trajectories have no jumps (here, it is only 10%). I will try to play a bit more with the parameters if I can find such an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants