New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unicode normalization and IDNA encoding to qute-pass userscript #8133
base: main
Are you sure you want to change the base?
Conversation
…or the 'pass' mode (gopass support missing)
@The-Compiler Would you mind having a look at this? |
I don't use qutebrowser or qute-pass anymore, sorry. |
I can take a look later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So let me see if I get this right: the idea is to encode the domain of the requested URL, and encode all the domains stored in the pass store, to ensure we're comparing apples to apples. I think this makes sense.
I left some comments on stuff that's being computed over and over with no need.
…id repeated computations
You got that right.
I have moved these out of the loops to optimize that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now 👌
I have implemented support for Internationalized Domain Names (IDNA). Currently, this only kicks in when the normal 'pass' mode (not 'gopass') is used because I am no gopass user so I could not test this right now.
@cryzed You are listed as script author, would you mind having a look at this?