Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unicode normalization and IDNA encoding to qute-pass userscript #8133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DrTobe
Copy link

@DrTobe DrTobe commented Mar 18, 2024

I have implemented support for Internationalized Domain Names (IDNA). Currently, this only kicks in when the normal 'pass' mode (not 'gopass') is used because I am no gopass user so I could not test this right now.

@cryzed You are listed as script author, would you mind having a look at this?

@DrTobe
Copy link
Author

DrTobe commented May 23, 2024

@The-Compiler Would you mind having a look at this?

@The-Compiler
Copy link
Member

I've never used either qute-pass or pass, so I can't say much. Maybe @bascht or @lufte have an opinion on this?

@cryzed
Copy link
Contributor

cryzed commented May 23, 2024

I don't use qutebrowser or qute-pass anymore, sorry.

@lufte
Copy link
Member

lufte commented May 23, 2024

I can take a look later.

@lufte lufte self-assigned this May 23, 2024
Copy link
Member

@lufte lufte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So let me see if I get this right: the idea is to encode the domain of the requested URL, and encode all the domains stored in the pass store, to ensure we're comparing apples to apples. I think this makes sense.

I left some comments on stuff that's being computed over and over with no need.

misc/userscripts/qute-pass Outdated Show resolved Hide resolved
misc/userscripts/qute-pass Outdated Show resolved Hide resolved
@DrTobe
Copy link
Author

DrTobe commented May 23, 2024

So let me see if I get this right: the idea is to encode the domain of the requested URL, and encode all the domains stored in the pass store, to ensure we're comparing apples to apples. I think this makes sense.

You got that right.

I left some comments on stuff that's being computed over and over with no need.

I have moved these out of the loops to optimize that.

Copy link
Member

@lufte lufte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now 👌

@toofar toofar added this to the v3.3.0 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants