Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update no_pdfjs.html #7721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tylerwolf35
Copy link

Small change to update the "no_pdfjs" page to make manual instruction more clear. I don't know if this necessarily warrants a commit but would definitely make things easier for some users.

@The-Compiler The-Compiler added this to Inbox in Pull request backlog via automation Jun 27, 2023
@The-Compiler
Copy link
Member

Thanks for the PR @tylerwolf35 and sorry for the radio silence! I'll try to prioritize this once I get back around to merging PRs. Right now I'm focused on getting Qt 6 and qutebrowser v3.0.0 out of the door first.

With that, it also won't be required anymore to use the legacy PDF.js distribution for Qt 6, so I'd like to only display this when using Qt 5 still (by passing machinery.IS_QT5 into the template in qutebrowser/browser/pdfjs.py and checking for it).

Also, at least the Archlinux package name above should probably also point to pdfjs-legacy instead in that case.

If you prefer, I can take care of those things when I get back around to PRs though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants