add pass command instead of password in clear text into add-nextcloud-bookmarks script #7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The-Compiler
requested changes
Apr 27, 2023
There was a problem hiding this comment.
Can you please keep the existing functionality where the script prompts the user for settings, and only add this on top of it? I don't see a reason why it should be removed.
Also, please use subprocess.run with capture_output=True, text=True instead of hand-rolling things with subprocess.Popen.
|
Hi @The-Compiler , I have keep the input option and use subprocess. I let you check vlp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use to publish my dot files and the add-nextcloud-bookmarks.ini file was included into the repo with my password.
I add the option to use a pass command instead of password in clear text.