modified message when overriding existing quickmark

[vhadzhiev]

Modified the message when the user wants to create a new quickmark and quickmark with that slug already exists. The new message shows the current marked URL and asks if the user wants to replace it. Closes #7622.

[vhadzhiev]

nitpick: The commit message has a typo. 😉

10x, :)

[The-Compiler]

Thanks! I added a suggestion on a better message wording.

The failing tests should be fine, looks like we have a couple of new flakiness issues with the recent Qt 6 merge.

[mschilli87]

LGTM now, though I'd prefer squashing the second commit into the first one for a cleaner Git log.

[The-Compiler]

Looks like there was a syntax error in my suggestion - sorry! Could you please fix that up?

If you think that useful I can start refactoring the files to f-string in my free time.

Thanks for the offer - but there are tools like pyupgrade and flynt which can automate that work. The main issue right now is that doing so introduces a lot of code churn, causing more conflicts which currently open PRs. But for 4.0.0 we plan to take that step: #1455.

[vhadzhiev]

Looks like there was a syntax error in my suggestion - sorry! Could you please fix that up?

If you think that useful I can start refactoring the files to f-string in my free time.

Thanks for the offer - but there are tools like pyupgrade and flynt which can automate that work. The main issue right now is that doing so introduces a lot of code churn, causing more conflicts which currently open PRs. But for 4.0.0 we plan to take that step: #1455.

I can do it, but this will probably create new commit. And I'm not very sure how to deal with the squashing.

LGTM now, though I'd prefer squashing the second commit into the first one for a cleaner Git log.

Maybe you can squash everything after that?

[The-Compiler]

Don't worry about it - I can indeed just squash-merge this.

[arza-zara]

The \n doesn't work in the title, and anyway it looks a bit better and is wrappable as body text

Suggested change

	title=f"Override existing quickmark?\nOld URL: {self.marks[name]}",
	title=f"Override existing quickmark?",
	text=f"Old URL: {self.marks[name]}",