Fix hints not finding elements from shadow roots #7617
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I recently discovered qutebrowser and instantly became a fan of it :) However I'm working with Shadow DOM currently so the lack of shadow dom support became a blocker for being able to fully use it.
As a quick fix, this change modifies
find_css
function so that it recursively collects elements withshadowRoot
to a list, and then adds the clickable elements from those shadowRoots to the returned result. AFAIK there isn't any easier way of finding all shadowRoots in a page (as also seems to be discussed in #3569)This change should at least partially resolve #3569.