Preserve filename in temporary downloads #7599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The yet-to-be-merged #5261 may be related here. |
|
Ah thanks, I did not see that one. Or the open issues regarding this. #5241 My approach is quite different, so I'll leave this one up for review too. |
Ram-Z
force-pushed
the
preserve-filename-in-tempdownload
branch
2 times, most recently
from
b8cfe9e
to
d8db991
Compare
Ram-Z
force-pushed
the
preserve-filename-in-tempdownload
branch
2 times, most recently
from
58047ae
to
01e12bc
Compare
Ram-Z
force-pushed
the
preserve-filename-in-tempdownload
branch
from
01e12bc
to
c465e92
Compare
Ram-Z
force-pushed
the
preserve-filename-in-tempdownload
branch
from
c465e92
to
5dd6e06
Compare
When downloading a file into a temporary location for external open or pdfjs, it used to prepend a random string to the filename. This means that downloading a file opened with pdfjs would have an unwanted mangled filename. Instead of adding a prefix to the filename, this puts the file with its filename intact in a unique temporary directory.
Ram-Z
force-pushed
the
preserve-filename-in-tempdownload
branch
from
5dd6e06
to
edff7c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading a file into a temporary location for external open or pdfjs, it used to prepend a random string to the filename. This means that downloading a file opened with pdfjs would have an unwanted mangled filename.
Instead of adding a prefix to the filename, this puts the file with its filename intact in a unique temporary directory.
Noteworthy changes:
filenamemust not contain a path separator has been lifted, it seems to work just fine (on linux)filenameis obviously not a good name anymore if it contains path separators