Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show current quickmark URL in overwrite dialog #7622

Open
benedikt-bartscher opened this issue Mar 16, 2023 · 1 comment · May be fixed by #7635
Open

Show current quickmark URL in overwrite dialog #7622

benedikt-bartscher opened this issue Mar 16, 2023 · 1 comment · May be fixed by #7635
Labels
component: ui Issues related to the user interface. component: urlmarks Issues related to bookmarks/quickmarks easy Issues which are likely to be a good fit for first-time contributors. priority: 2 - low Issues which are currently not very important.

Comments

@benedikt-bartscher
Copy link

benedikt-bartscher commented Mar 16, 2023 •
edited

When you want to create a new quickmark and a quickmark with that slug already exists, qutebrowser currently asks the user if he wants to overwrite the quickmark. I often wonder what URL is in the current one, it would be awesome if qutebrowser could display the current quickmarks URL in this dialog.
@The-Compiler
Copy link
Member

Makes sense! If someone wants to take a stab at this, the place to look at would be quickmark_add in browser/urlmarks.py:

qutebrowser/qutebrowser/browser/urlmarks.py

Lines 187 to 190 in 3d56f57

if name in self.marks:
message.confirm_async(
title="Override existing quickmark?",
yes_action=set_mark, default=True, url=url)

@The-Compiler The-Compiler added component: ui Issues related to the user interface. easy Issues which are likely to be a good fit for first-time contributors. priority: 2 - low Issues which are currently not very important. component: urlmarks Issues related to bookmarks/quickmarks labels Mar 16, 2023
@vhadzhiev vhadzhiev linked a pull request Mar 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ui Issues related to the user interface. component: urlmarks Issues related to bookmarks/quickmarks easy Issues which are likely to be a good fit for first-time contributors. priority: 2 - low Issues which are currently not very important.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modified message when overriding existing quickmark vhadzhiev/qutebrowser
2 participants
@The-Compiler @benedikt-bartscher