Make non-collapsible titledpanes not highlight on mouseover

[alanocallaghan]

No description provided.

[finglis]

In the process of adding the class to other titled panes, please don't merge yet :)

[finglis]

So edited a few more that appeared clickable when they shouldn't be (as they are not collapsible).
I wasn't able to test ExportChartPane.java, KaplanMeierDisplay.java as I couldn't find them in the running app but I believe the latter doesn't need adjusting.
Additionally, I wasn't able to launch TMASummaryViewer.java in the app (File -> TMA data -> launch TMA data viewer) so added it as a comment. Unsure if this is the case for anyone else?
Lastly I believe the simplifyTitledPane class of PaneTools.java seems to not be used at all. Unsure if I'm missing something, if not should it be used or removed?

[alanocallaghan]

That version of simplifyTitledPane was only removed/deprecated a few months ago so I'd be inclined to let it linger until 1.0 at least a728924

[petebankhead]

If I understand correctly, this PR is to make the top title change on hover but not the bottom one - because the top one can be expanded/collapsed, but the bottom one can't.

Screen.Recording.2024-05-21.at.17.57.47.mov

tbh I'd never noticed this or seen it as problematic.

If you think it needs a fix, then should it not go into qupath-fxtras? This is the new home to simplifyTitledPane... but then you'd need to load an external .css (like with the simplify method), e.g.

public void makeNonCollapsible(TitledPane pane) {
    pane.setCollapsible(false);
    // Whatever other styling is needed here
}

Hard-coding a reference to the CSS class feels a bit brittle to me, and is tied very much to QuPath in a way that is unusable elsewhere. And I imagine we'll end up with inconsistencies as we'll forget / extension writers won't know to add this style class... which to me seems potentially worse.

You could also change main.css to avoid any change on hover at all, but personally I think it looks quite nice and helps titles stand out.

Was there any particular user complaint or confusion caused by the default JavaFX approach of slightly changing the behavior on hover, regardless of the 'collapsible' status?

[alanocallaghan]

tbh I'd never noticed this or seen it as problematic.

Fair yeah, it's been bugging me, but I am happy to allow it to continue to bug me if it's not consequential or shared by others

You could also change main.css to avoid any change on hover at all, but personally I think it looks quite nice and helps titles stand out.

It certainly helps for collapsible panes