Allow logging of header name and value bytes #414
Conversation
| @@ -505,10 +505,20 @@ H3HeadersFrame = { | |||
| ~~~ | |||
| {: #h3-headersframe-def title="H3HeadersFrame definition"} | |||
|
|
|||
| HTTP/3 can transport field names or values that are not valid; see {{Section 4.2 | |||
There was a problem hiding this comment.
| HTTP/3 can transport field names or values that are not valid; see {{Section 4.2 | |
| HTTP/3 can encode field names or values that are not valid; see {{Section 4.2 |
| ? name_text: text | ||
| ? name_bytes: hexstring | ||
| ? value_text: text | ||
| ? value_bytes: hexstring |
There was a problem hiding this comment.
Can we avoid renaming the existing fields?
There was a problem hiding this comment.
If we decide on using the same approach here as in #412, and there we call it reason + reason_bytes instead of reason_text + reason_bytes, then yeah, we should be consistent here as well and keep name + name_bytes + value + value_bytes
| @@ -505,10 +505,20 @@ H3HeadersFrame = { | |||
| ~~~ | |||
| {: #h3-headersframe-def title="H3HeadersFrame definition"} | |||
|
|
|||
| HTTP/3 can transport field names or values that are not valid; see {{Section 4.2 | |||
There was a problem hiding this comment.
Not valid what? Valid UTF-8? Valid semantically? valid in terms of range of bytes that are represented? etc.
| ? name_text: text | ||
| ? name_bytes: hexstring | ||
| ? value_text: text | ||
| ? value_bytes: hexstring |
There was a problem hiding this comment.
If we decide on using the same approach here as in #412, and there we call it reason + reason_bytes instead of reason_text + reason_bytes, then yeah, we should be consistent here as well and keep name + name_bytes + value + value_bytes
Fixes #413