Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw_ack_delay field to AckFrame #337

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add raw_ack_delay field to AckFrame #337

wants to merge 1 commit into from

Conversation

rmarx
Copy link
Contributor

@rmarx rmarx commented Nov 10, 2023

As requested by Damien Neil on the QUIC wg mailing list on November 9, this adds an option to log the raw ack_delay value seen in the AckFrame, as opposed to the scaled value (for which external "global" state is needed, that is not always present in all code paths).

Copy link
Collaborator

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote to the list, I don't think we should do this. Strongly opposed to this change.

@rmarx
Copy link
Contributor Author

rmarx commented Nov 10, 2023

@marten-seemann thank you for the feedback.
My reply to the list is pending moderation (no clue why), just so you know I also had some explanation in there, so we'll see what others say. I don't feel strongly this HAS to be in there, but I do understand the ask here.

@marten-seemann
Copy link
Collaborator

for which external "global" state is needed, that is not always present in all code paths

I don't think this is a reasonable ask. We discussed this a few months ago on the list, and the next QUIC RFC might need to add some clarifying text that ACK delay isn't used in the Initial and Handshake PN space. This is completely independent of qlog, and conflating those two would be bad design.

In the end, a QUIC stack will need to decode the value at some point, there's nothing it can do with an unscaled ACK delay. The only advantage to introducing the unscaled_ack_delay is that a QUIC stack can apply the scaling after qlogging the frame. I don't think this strikes the right balance (as I've argued on list). Among all the qlog implementations around today, no other QUIC stack ran into this problem, so this seems like we're adding logging in order to work around an architectural problem in one particular single stack here.

@LPardue
Copy link
Member

LPardue commented Nov 17, 2023

FWIW Its easier to track feature requests as issues rather than PRs (I'm guilty of this too).

Propose closing this with no action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants