Use even numbers for path ID #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yanmei-Liu
reviewed
Apr 18, 2024
Co-authored-by: Yanmei Liu <healing4d@gmail.com>
Co-authored-by: Yanmei Liu <healing4d@gmail.com>
Co-authored-by: Yanmei Liu <healing4d@gmail.com>
Co-authored-by: Yanmei Liu <healing4d@gmail.com>
|
Thanks for the fixes, @Yanmei-Liu |
Yanmei-Liu
approved these changes
Apr 19, 2024
qdeconinck
approved these changes
Apr 19, 2024
Co-authored-by: Quentin De Coninck <quentin.deconinck@uclouvain.be>
|
Do we generally have consensus for the even/odd split? Or do we need to confirm this on the list/in the interim before we merge? As I just wrote in PR #329 I don't think we fully have consensus yet if we want to specify the server-initiated paths part in this doc or separately. However, I think think we can already merge this PR and keep discussing in PR #329. |
|
Closing this PR after the 6/4/2024 interim. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specifies using even number path identifiers. It anticipates the possibility of using the odd numbered identifiers for server-initiated paths, but does not specify how to do that. As a result, it is much simpler than PR #329.
Close #328