Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split Term into Term and IndexingTerm #2366

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

split Term into Term and IndexingTerm #2366

wants to merge 1 commit into from

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Apr 22, 2024 •
edited

  • split term and indexing term
  • add JsonTermSerializer
  • cleanup
  • clippy

This splits Term into Term and IndexingTerm. Term is used for querying, IndexingTerm during indexing.
This allows to reduce the complexity of Term and a more compact format for IndexingTerm by dropping the type marker at byte 5.

Part of: #1795

@PSeitz PSeitz requested a review from fulmicoton April 22, 2024 02:57
@fulmicoton
Copy link
Collaborator

As discussed offline, this looks good but let's not merge not progress on #1795 at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulmicoton fulmicoton Awaiting requested review from fulmicoton

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PSeitz @fulmicoton