Add preserve original on ascii folding filter. #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassot
force-pushed
the
fmassot/add-preserve-original-ascii-folding
branch
from
0f95465
to
90b9059
Compare
fmassot
force-pushed
the
fmassot/add-preserve-original-ascii-folding
branch
from
ab593ca
to
36d585a
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2126 +/- ##
==========================================
+ Coverage 94.37% 94.38% +0.01%
==========================================
Files 321 319 -2
Lines 60821 60791 -30
==========================================
- Hits 57401 57379 -22
+ Misses 3420 3412 -8
|
| if !self.token_mut().text.is_ascii() { | ||
| // ignore its already ascii | ||
| to_ascii(&self.tail.token().text, self.buffer); | ||
| text_has_changed = to_ascii(&self.tail.token().text, self.buffer); |
There was a problem hiding this comment.
Can text_has_changed == false happen here even though the is_ascii test above already failed?
There was a problem hiding this comment.
just checked the to_ascii and as you can expect it will not change a full ascii text... I will fix that, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as lucene filter: https://lucene.apache.org/core/6_4_1/analyzers-common/org/apache/lucene/analysis/miscellaneous/ASCIIFoldingFilter.html
There is a minor difference between the two filters with
preserve_originalset totrueand when the original token is different from the folded token: the lucene filter first emits the folded token and then the original token, whereas tantivy first emits the original token and then the folded one.