The super large grace period of 1 day has proved to be harmful on #4986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilload
approved these changes
May 15, 2024
Cicada. This PR lowers it to 2h. For reminder, starting the detection of the node as dead, the node gets into a zombie state for 1h. We do share its KVs. From timeofdeath+1h to timeofdeath+2h, we won't share the node. After 2h, we will delete the node from the state.
fulmicoton
force-pushed
the
decrease_dead_node_grace_period
branch
from
b575de8
to
2143a76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cicada.
This PR lowers it to 2h.
For reminder, starting the detection of the node as dead, the node gets into a zombie state for 1h.
We do share its KVs.
From timeofdeath+1h to timeofdeath+2h, we won't share the node.
After 2h, we will delete the node from the state.
(We still do not really understand why the dead node number would keep increasing)