Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh metastore on Lambda searcher #4985

Merged
merged 10 commits into from
May 16, 2024
Merged

Refresh metastore on Lambda searcher #4985

merged 10 commits into from
May 16, 2024

Conversation

rdettai
Copy link
Contributor

@rdettai rdettai commented May 15, 2024

Description

Fix outdated metastore issues on the search side

  • add configurable polling interval on searcher
  • change polling ticker to DELAY to avoid bursts after longer Lambda inactivity

Also:

  • adding some docs summarizing all configurable env variables
  • made indexer timeout configurable in CDK script to fix the HDFS indexer example work out of the box
  • some refactoring/comments on the LazyFileBackedIndex to help readability

How was this PR tested?

Intensive testing on our cloud account.

@rdettai rdettai self-assigned this May 15, 2024
@rdettai rdettai changed the title Lambda-metastore-refresh Refresh metastore and Lambda searcher May 15, 2024
@rdettai rdettai requested a review from guilload May 15, 2024 10:26
@rdettai rdettai force-pushed the lambda-metastore-refresh branch 6 times, most recently from eadc97c to dc43c1d Compare May 16, 2024 13:22
@rdettai
Copy link
Contributor Author

rdettai commented May 16, 2024

This PR is still failing when creating a new index with:

internal error: could not find checkpoint for index `hdfs-logs:XXXXXXXX` and source `_ingest-lambda-source`

Tried to create the _ingest-lambda-source with CreateIndexRequest, but that is not possible because identifiers must match the following regular expression: ^[a-zA-Z][a-zA-Z0-9-_\.]{2,254}$.

This problem is orthognal to this fix so I'm merging this anyway.

@rdettai rdettai enabled auto-merge (squash) May 16, 2024 20:15
@rdettai rdettai changed the title Refresh metastore and Lambda searcher Refresh metastore on Lambda searcher May 16, 2024
@rdettai rdettai merged commit 0e4ae0b into main May 16, 2024
5 checks passed
@rdettai rdettai deleted the lambda-metastore-refresh branch May 16, 2024 20:26
@rdettai rdettai mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants