Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tokio runtimes metrics #4984

Merged
merged 1 commit into from
May 16, 2024
Merged

Add Tokio runtimes metrics #4984

merged 1 commit into from
May 16, 2024

Conversation

guilload
Copy link
Member

@fulmicoton, @trinity-1686a, which metrics interest you: tokio-metrics?

@guilload guilload force-pushed the guilload/tokio-runtimes-metrics branch 2 times, most recently from b672a41 to b1032b8 Compare May 14, 2024 20:00
@fulmicoton
Copy link
Contributor

busy_ratio seems very valuable.

@trinity-1686a
Copy link
Contributor

trinity-1686a commented May 15, 2024

for task metrics:
total_scheduled_duration, total_poll_duration, total_slow_poll_{count,duration} looks interesting to see if we do too much compute on the runtime, and if tasks would like to work but cannot because of that.
possibly their derived variant too: mean_scheduled_duration, mean_poll_duration, slow_poll_ratio
for runtime metrics:
total_busy_duration and its derived busy_ratio could be interesting.

@guilload guilload force-pushed the guilload/tokio-runtimes-metrics branch 5 times, most recently from 00c739d to afed9d5 Compare May 15, 2024 19:38
@guilload guilload force-pushed the guilload/tokio-runtimes-metrics branch from afed9d5 to 8ae1353 Compare May 15, 2024 19:44
@guilload guilload requested a review from fulmicoton May 15, 2024 20:01
@guilload
Copy link
Member Author

I'm only adding runtime metrics in this PR because task metrics required instrumenting tasks individually with a TaskMonitor.

@guilload guilload merged commit fbb8580 into main May 16, 2024
5 checks passed
@guilload guilload deleted the guilload/tokio-runtimes-metrics branch May 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants