Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SendBatchToTarget #599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Yu-Xie
Copy link

@Yu-Xie Yu-Xie commented Nov 10, 2023

This is a re-write of #576 after addressing feedbacks and rebasing.

Related issue: #555

@Yu-Xie
Copy link
Author

Yu-Xie commented Nov 10, 2023

@Yu-Xie if you would change SendAppToTarget to SendBatchToTarget and SaveMessagesAndIncrNextSenderMsgSeqNum to SaveBatchAndIncrNextSenderMsgSeqNum I will merge. I'd like to keep func names immediately obvious to prevent accidental misuse. Also if the FileStore and MongoStore impls are easy enough to implement for you, please do so.

@ackleymi This addresses your feedbacks (renaming & implementing all the stores) -- Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant