Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unitfile for ncm-cdispd, remove initscripts/chkconfig support #61

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

stdweird
Copy link
Member

Add unitfile for ncm-cdispd.

Possible issue: the configfile options "--quiet/-D" should not be set; and pidfile and logfile options are ignored

@jrha jrha added this to the 24.3 milestone Mar 27, 2024
@jouvin
Copy link
Contributor

jouvin commented Apr 2, 2024

@stdweird I open a PR on your PR to remove references to chkconfig that requires to define chkconfig as dependency for ncm-cdispd, as it is a source of problem on EL9. This breaks the compatibility with EL6 but it is also the case in cdp-listend (quattor/cdp-listend#33).

In addition to the potential chicken&egg problem with chkconfig packages if it is not installed first, these changes fix the boot ordering issue between ncm-cdispd and NetworkManager (see quattor/configuration-modules-core#1671). The new version has been tested successfully at IJCLab (EL9).

I let you fix the unit test problems that are not introduced by my changes.

@jouvin
Copy link
Contributor

jouvin commented Apr 17, 2024

@stdweird please could you merge my PR to your branch so that we have a branch with everything. This is really required for EL9 support.

- chkconfig dependency is a source of problems in EL9
- Breaks EL6 support
@stdweird stdweird changed the title add unitfile for ncm-cdispd add unitfile for ncm-cdispd, remove initscripts/chkconfig support Apr 17, 2024
@ned21
Copy link
Contributor

ned21 commented Apr 17, 2024

Not sure it's completely accurate but adding the backwards incompatible label to highlight in the release notes that this drops EL6 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants