ncm-network: nmstate change the way dummy interfaces are created. #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrha
previously approved these changes
May 3, 2024
use key instead of index to label dummy interface. This will allow referencing the correct vip elsewhere in pan or external applications. Add tests.
aka7
force-pushed
the
ncm_network_nmstate_dummy_fix
branch
from
a3780b5
to
c6f5502
Compare
jrha
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use key instead of index to label dummy interface. This will allow referencing the correct vip elsewhere in pan or external applications. Add tests.
Why the change is necessary.
Allow creation of dummy interface in nmstate using labels instead of indexing.
What backwards incompatibility it may introduce.
if using nmstate dummy interface, profile name will change from dummy0 to the label given to dumm interface, so if its myvip, it will change from dummy0 to dummy_myvip. I believe noone is using this currently. This was feature only added in nmstate.