Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncm-spma: Remove support from groups from spma yumng backend #1148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrha
Copy link
Member

@jrha jrha commented Jul 25, 2017

Resolves #952.

Would be nice if @jnovy could look over this.

@jrha jrha added this to the 17.8 milestone Jul 25, 2017
@jrha jrha requested a review from ned21 August 30, 2017 13:44
@ned21
Copy link
Contributor

ned21 commented Aug 30, 2017

hmm... I have a feeling we had to abandon this change on our RH6 builds because we couldn't prove that it didn't introduce unexpected changes. So we might want to keep this around but block its use on RH7+. Will check and come back.

@jnovy
Copy link

jnovy commented Aug 31, 2017

You are well ahead of time @jrha :-)

I like the idea of getting rid of groups as they are. The yumng related patch breaks stuff for us in RHEL5 and 6 where we still use groups. Since RHEL7 I made the following modification so that spma would be happy in case of either groups being present or not:

my $groups = defined($config->getElement(GROUPS_TREE)) ? $config->getElement(GROUPS_TREE)->getTree() : [];

Still leaving the rest of the code there. In RHEL7 we just make /software/groups/names = list(); i.e. empty and use pregenerated groups. We use the same code in RHEL5,6 which works with the actual groups being used.

@jrha jrha removed this from the 17.8 milestone Aug 31, 2017
@jrha
Copy link
Member Author

jrha commented Aug 31, 2017

Ok, I'll leave things as they are and remove the milestone for now.
I get the feeling you are not using the mainline code base though?

@jrha jrha force-pushed the spma-yumng-remove-groups branch from 1f4d7af to f82c84e Compare July 28, 2023 13:36
@jrha jrha marked this pull request as draft August 22, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants