Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdp-listend: Factor out calls to notification handlers #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cdp-listend: Factor out calls to notification handlers #23

wants to merge 1 commit into from
+15 −15

Conversation

jrha
Copy link
Member

@jrha jrha commented Feb 8, 2022

  • Factor out calls to notification handlers to a new subroutine as much of the code is common.
  • Log unknown notification types.
  • Improve slightly ambigious log messages regarding timing.

@jrha
cdp-listend: Factor out calls to notification handlers
e4fd66e 
* Factor out calls to notification handlers to a new subroutine as much of the code is common.
* Log unknown notification types.
* Improve slightly ambigious log messages regarding timing.
@jrha jrha added the cleanup label Feb 8, 2022
@jrha jrha added this to the 22.3 milestone Feb 8, 2022
@jrha jrha requested a review from stdweird February 11, 2022 11:45
@jrha jrha modified the milestones: 23.6, 23.next Jun 23, 2023
@jrha jrha modified the milestones: 23.9, 23.next Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdweird stdweird Awaiting requested review from stdweird

Assignees
No one assigned
Labels
cleanup
Milestone
24.next
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jrha