Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker: pass archetype to the object profile #89

Open
wants to merge 2 commits into
base: upstream
Choose a base branch
from

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented May 27, 2018

This change allows the broker to pass the host archetype to the object profile as '/system/archetype/name`.

It includes an improvement of pan_variable() function to define a variable based on another variable, allow a construct like:

variable LOADPATH = list(ARCHETYPE);

This pan_variable() change was originally made for an earlier version of this PR and is now no longer used but has been kept as it it potentially useful.

Fixes #88
Contributes to #90

@urbonegi
Copy link

Let's finish with this one: #87
As i think we nearly have an agreement. This will allow you to move forward. After we merge it - let's get back to this one, ok?

@jouvin
Copy link
Contributor Author

jouvin commented Jun 30, 2018

I updated this PR (and its description) to reflect the new implementation, based on assigning /system/archetype/name with the archetype defined in the database, as suggested by @jrha in #88.

@jouvin
Copy link
Contributor Author

jouvin commented Jun 30, 2018

BTW, if/when this PR is accepted, it would be good to make /system/archetype/name mandatory in the schema.

"""
pan(OBJ) -- return a string representing OBJ in the PAN language

:param quoted: if true, a string value is quoted. Can be set to fale is the value is
Copy link
Member

@jrha jrha Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false if the

@jouvin
Copy link
Contributor Author

jouvin commented Jul 12, 2018

@urbonegi @ned21 have you had the time to look at this PR? Your feedback is welcome!

Aquilon main user and others added 2 commits August 16, 2018 12:48
- Do not replace the variable used as the value by its actual value

Change-Id: Id517acec7b0231f9c7333346ca7a49e806823a60
- archetype name assigned to /system/archetype/name

Change-Id: Ice4559238bb36e299fc0f172c2fc13f357c9f13f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants