Relaxed feature template checks in bind feature and manage commands #112
Conversation
|
As stated in the issue this fixes, I think it's a bad idea to break the name spacing in this way. If the patch were to be accepted, all new code paths would need unit test coverage. |
|
@ned21 I don't really understand your comment here. I don't think this PR breaks name spacing in any way. Name spacing in Pan is relative to the loadpath and this is the real power of it. This has been the important feature (introduced around panc v6 or v7, not a feature from the origin) that enabled the template library concept, making it feasible. So this PR just allows to use the full power of Pan name spacing with Aquilon, something that was somewhat restricted by the initial implementation. But as said in the issue, it has a price (like the current implement has the price of restricting the power of name space + loadpath combination), this is why I propose to have it a configuration option that allows each site to makes its own decision about the model which is most adapted for it. |
|
I really don't like the idea of allowing features at the root level, users (and tooling) expect to see nothing but archetypes there, I do however like the idea of sharing features between archetypes. See my comment on #111 about what we did to allow sharing at RAL. |
jouvin
force-pushed
the
feature_template_check
branch
from
a199199
to
a50cc8b
Compare
- Enable sharing of feature definitions between several archetypes Contributes to quattor#111 Change-Id: Ic15880018c615add765724ff82e24acf337d4912
Change-Id: Ida56e61fae9840d45afe17ee0ca4b99856fb6d08
When config option relaxed_feature_template_check is true (default: false), only display a warning if the template existence cannot be assessed rather than raising an exception. This allows to support direct use of features defined in the plenary templates (e.g. features from the template library). Contributes to quattor#111 Change-Id: I0b3319cd39a2c962da0464c511a2c42de2595407
|
After discussion, decision to implement both features with separate options, using the RAL approach of a directory dedicated to shared features. |
This PR addresses issue #111 by:
relaxed_feature_template_checkis true (false by default) where a warning is displayed if the template existence is assessed rather than raising an exception. This allows to support direct use of template library features.Not done yet:
aq manageif--skip_auto_complleis not present: not clear what the added value would be as it will not help much is you don't haverelaxed_feature_template_check=Trueand will only remove the warning if you have it.Successfully tested at LAL.