New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix index off by one error for flux percential ratio #11

Open

stevenstetzler wants to merge 1 commit into quatrope:master from stevenstetzler:master

stevenstetzler commented Nov 23, 2019

Here's the PR. Perhaps it would be good to rename

lc_length = len(sorted_data) - 1

F_60_index = int(math.ceil(0.60 * lc_length))
...

to

lc_length = len(sorted_data)
lc_index = lc_length - 1

F_60_index = int(math.ceil(0.60 * lc_index))
...

or to

lc_index = len(sorted_data) - 1

F_60_index = int(math.ceil(0.60 * lc_index))
...

to keep the semantics of the variable lc_length consistent.


          Fix index off by one error for flux percential ratio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment