fix client execwrapper not using full path to script #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clients execwrapper was using the scriptName instead of the full path fileName to execute scripts leading to scripts only being found and executed if the script directory was also in $PATH or a executable with the same name as the script was in $PATH. This could also lead to confusion as it executes whatever is in $PATH instead of the actual script in quassels directories.
Tatsh
added a commit
to Tatsh/gentoo
that referenced
this pull request
May 3, 2024
From quassel/quassel#609 Signed-off-by: Andrew Udvare <audvare@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The clients execwrapper was using the scriptName instead of the full path fileName to execute scripts leading to scripts only being found and executed if the script directory was also in $PATH or a executable with the same name as the script was in $PATH.
This could also lead to confusion as it executes whatever is in $PATH instead of the actual script in quassels directories.