client: Fix DayChange invalid index w/future msgs #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crash when generating a DayChange message if somehow the message model only has messages from the future. Though unlikely, this may happen with IRCv3 server-time if a server specifies timestamps in the future. Potentially fixes https://bugzilla.redhat.com/show_bug.cgi?id=2072127 Add comments to document this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In short
DayChangeif there's only messages from the futureserver-timeif server's desynced, or if the Quassel client or core have the wrong timeTesting
I tried to recreate this by patching the Quassel core to only send timestamps from the future, etc. Unfortunately, I could not reproduce this crash. At worst, this might just be ineffective.
Testing confirms that at least the debug message works if the Quassel client is patched to jump to it.