Start a CocoaHelper class for macOS 10.12 and add a few improvements to the client #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added the start of a CocoaHelper class to customize how windows look. things in there should be turned into settings and piled up in the future. - Removed the "stop editing on unfocus" behaviour the topic widget had - Only the highest mode prefix shows in front of a nick when it's enabled. Ideally the core should sort them and there should be an attempt to grab the first one. This is an improvement that will probably be made later. - Added makeHumanReadable and makeIrcReadable from Konversation's replaceFormattingCodes and replaceIRCMarkups. It was integrated in the topic widget, so that style bytes are converted to and from human-readable format when the topic is being edited. It was also integrated in the input widget. - Added the Edit menu from PR quassel#176 on quassel's repo as a function to cocoahelper - Fix emojis on macOS by leaving a tiny bit of space between the lines
|
Belatedly, thank you for looking into this! I'll have to figure out an (ahem) totally-legit macOS setup to properly review this, but, meanwhile, I appreciate the attention to macOS detail. Fortunately, stock Quassel now has the "highest mode prefix" option, and the other aspects can be brought forward. |
|
Thanks for your interest, I like the idea that I had with the CocoaHelper class, as it allows for some nice and sometimes needed tweaks on macOS without much effort. I recently had the urge to fix up my 2011 MBP one last time, I will revisit this if I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this fork has been lying around for a while and it brings some pretty good improvements to macOS 10.12 and later, as well as the start of macOS-specific code via the CocoaHelper class. I wanted to clean up the code and the commits, but some things got in the way and I forgot about this repository for a while.
Sadly, I don't have a Mac anymore and I don't plan to buy one in the near future. But if I ever do or if I eventually setup a macOS virtual machine, I'll definitely revisit it. The CocoaHelper class could be given its own pull request, but it should work right now, and I don't have something to test it on if I play with the code.
This is from my original commit:
Added makeHumanReadable and makeIrcReadable from Konversation's replaceFormattingCodes and replaceIRCMarkups. It was integrated in the topic widget, so that style bytes are converted to and from human-readable format when the topic is being edited. It was also integrated in the input widget.I've reverted "Added makeHumanReadable and makeIrcReadable from Konversation's "replaceFormattingCodes and replaceIRCMarkups.", I'm still working on this on a separate branch.
There are also a few bugfixes and opinionated commits. For example, I've changed the way the nick colours are chosen so that the colour depends on the nick's size, this way two nicks of the same size more rarely have the same colour.