enable simulation of controlled gates in classical simulator #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6589 +/- ##
=======================================
Coverage 97.81% 97.81%
=======================================
Files 1063 1063
Lines 91761 91796 +35
=======================================
+ Hits 89755 89793 +38
+ Misses 2006 2003 -3 ☔ View full report in Codecov by Sentry. |
GregDMeyer
commented
May 8, 2024
NoureldinYosri
requested changes
May 9, 2024
NoureldinYosri
requested changes
May 20, 2024
|
whoops, I realized why I wasn't seeing the linter errors locally---I was mistaken about what running |
NoureldinYosri
approved these changes
May 23, 2024
jselig-rigetti
pushed a commit
to jselig-rigetti/Cirq
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only X, CNOT, TOFFOLI, SWAP, and measurement are supported by
cirq.ClassicalStateSimulator. This pull request adds support for versions of the first four gates with an arbitrary number of controls (as generated by the.controlled()function).