Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove n_batches from daqsamplers.RateBaseCounter.sample_counts and subclasses #77

Open
gadamc opened this issue Feb 1, 2023 · 0 comments

Comments

@gadamc
Copy link
Collaborator

gadamc commented Feb 1, 2023

Upon review, there's no good reason for the sample_counts method in daqsamplers.RateBaseCounter and subclasses to have a "n_batches" option. Though unlikely, if the caller needs multiple sets of samples, they can call the function multiple times. Most (all?) of the time this function is called with n_batches = 1

@gadamc gadamc changed the title remove n_samples from daqsamplers.RateBaseCounter and subclasses remove n_batches from daqsamplers.RateBaseCounter.sample_counts and subclasses Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant