Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checks for "stage_controller" in piezoscanner.py #113

Open
gadamc opened this issue Jun 27, 2023 · 0 comments
Open

Remove checks for "stage_controller" in piezoscanner.py #113

gadamc opened this issue Jun 27, 2023 · 0 comments

Comments

@gadamc
Copy link
Collaborator

gadamc commented Jun 27, 2023

In the CounterAndScanner object defined in
https://github.com/qt3uw/qt3-utils/blob/main/src/qt3utils/datagenerators/piezoscanner.py
there are multiple lines where we check for the self.stage_controller (to essentially not be None).
However, this object cannot be instantiated without a stage_controller passed in. Thus, these checks are
pointless and should be removed.

https://github.com/qt3uw/qt3-utils/blob/main/src/qt3utils/datagenerators/piezoscanner.py#L42
https://github.com/qt3uw/qt3-utils/blob/main/src/qt3utils/datagenerators/piezoscanner.py#L60
https://github.com/qt3uw/qt3-utils/blob/main/src/qt3utils/datagenerators/piezoscanner.py#L95
https://github.com/qt3uw/qt3-utils/blob/main/src/qt3utils/datagenerators/piezoscanner.py#L122
https://github.com/qt3uw/qt3-utils/blob/main/src/qt3utils/datagenerators/piezoscanner.py#L164-L169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant