Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added handwired keyboard "derb_planck" #23684

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

der-b
Copy link

@der-b der-b commented May 8, 2024

Description

Add new handwired keyboard "derb_planck".

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/handwired/derb_planck/readme.md Outdated Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/config.h Outdated Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/config.h Outdated Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/config.h Outdated Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/info.json Outdated Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/rev1.c Outdated Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/rev1.h Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/rules.mk Outdated Show resolved Hide resolved
keyboards/handwired/derb_planck/rev1/info.json Outdated Show resolved Hide resolved
@der-b
Copy link
Author

der-b commented May 9, 2024

I adapted the code as suggested with one exception. See my commend above.

@der-b der-b requested a review from waffle87 May 9, 2024 18:11
@der-b
Copy link
Author

der-b commented May 10, 2024

Thanks for the clarification. I hope, that all issues are resolved.

PS: Sorry using rules.mk and config.h instead of the info.json. I used the official documentation and this tells on to use rules.mk and config.h

@der-b der-b requested a review from sigprof May 10, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants