Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Apluxs Pulsar XBOARD QS keyboard #23646

Closed
wants to merge 15 commits into from
Closed

Add Apluxs Pulsar XBOARD QS keyboard #23646

wants to merge 15 commits into from

Conversation

skylupin03
Copy link

@skylupin03 skylupin03 commented May 2, 2024 •
edited

Description

This is a PR to add the keyboard "Aplusx, PULSAR XBOARD QS" to QMK.

Thank you for taking the time to review this submission

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 2, 2024
zvecr
zvecr requested changes May 3, 2024
View reviewed changes
keyboards/aplusx_pulsar/xboard_qs/info.json Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/info.json Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/config.h Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/info.json Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/aplusx_pulsar/xboard_qs/xboard_qs.c Outdated Show resolved Hide resolved
skylupin03 and others added 11 commits May 3, 2024 19:50
@skylupin03 @zvecr
Update keyboards/aplusx_pulsar/xboard_qs/info.json
6f57163 
Co-authored-by: Joel Challis <git@zvecr.com>
@skylupin03 @zvecr
Update keyboards/aplusx_pulsar/xboard_qs/info.json
e7b3e7f 
Co-authored-by: Joel Challis <git@zvecr.com>
@skylupin03 @zvecr
Update keyboards/aplusx_pulsar/xboard_qs/keymaps/default/keymap.c
08a0563 
Co-authored-by: Joel Challis <git@zvecr.com>
@skylupin03 @zvecr
Update keyboards/aplusx_pulsar/xboard_qs/keymaps/via/keymap.c
d0ad2c3 
Co-authored-by: Joel Challis <git@zvecr.com>
@skylupin03 @zvecr
Update keyboards/aplusx_pulsar/xboard_qs/keymaps/default/keymap.c
e4b9ba8 
Co-authored-by: Joel Challis <git@zvecr.com>
@skylupin03 @zvecr
Update keyboards/aplusx_pulsar/xboard_qs/config.h
3efb769 
Co-authored-by: Joel Challis <git@zvecr.com>
@skylupin03 @zvecr
Update keyboards/aplusx_pulsar/xboard_qs/info.json
86a3b3a 
Co-authored-by: Joel Challis <git@zvecr.com>
@skylupin03
In order to PR, I learned from the teachings of <zvecr>, and I modifi…
3b99d4a 
…ed them
@skylupin03
Merge branch 'qmk:master' into pulsar_xboard_qs
ee990aa
@skylupin03
Update keymap.c
49cad21
@skylupin03
Update keymap.c
e8a67f2
@skylupin03 skylupin03 requested a review from zvecr May 3, 2024 14:17
@skylupin03
Copy link
Author

While learning while referring to other people's codes, I accidentally changed the code,
I'm so sorry. I revised it as carefully as possible
I'm sorry I'm not good enough

@zvecr zvecr changed the title Add Apluxs Pulsar XBOARD QS keyboard (1st commit) Add Apluxs Pulsar XBOARD QS keyboard May 11, 2024
@skylupin03
Copy link
Author

It's gotten a lot complicated. I'll clean it up and do PR again, thank you for reviewing it

@skylupin03 skylupin03 closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skylupin03 @zvecr