Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Kami65 PCB #23645

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

MaiTheSan
Copy link
Contributor

@MaiTheSan MaiTheSan commented May 1, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels May 1, 2024
@zvecr
Copy link
Member

zvecr commented May 2, 2024

Per the PR checklist,

  • PRs should contain the smallest amount of modifications required for a single change to the codebase
    • multiple keyboards at the same time is not acceptable

@MaiTheSan
Copy link
Contributor Author

Per the PR checklist,

  • PRs should contain the smallest amount of modifications required for a single change to the codebase

    • multiple keyboards at the same time is not acceptable

got it

@MaiTheSan MaiTheSan changed the title Add support for Kami65 and Ad-ware PCB Add support for Kami65 PCB May 2, 2024
keyboards/chickenman/kami65/info.json Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run qmk format-json -i keyboards/chickenman/kami65/info.json after making changes.

keyboards/chickenman/kami65/readme.md Outdated Show resolved Hide resolved
keyboards/chickenman/kami65/readme.md Outdated Show resolved Hide resolved
keyboards/chickenman/kami65/readme.md Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adhere to the rules.mk template.

Suggested change
# This file intentionally left blank

MaiTheSan and others added 6 commits May 2, 2024 19:21
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants