Prepare versioneer.py for Python 3.12. #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen first in [Debian bug #1058220], execution of the versioneer.py script fails with Python 3.12 with the following error: Traceback (most recent call last): File "/<<PKGBUILDDIR>>/setup.py", line 16, in <module> version=versioneer.get_version(), ^^^^^^^^^^^^^^^^^^^^^^^^ File "/<<PKGBUILDDIR>>/versioneer.py", line 1481, in get_version return get_versions()["version"] ^^^^^^^^^^^^^^ File "/<<PKGBUILDDIR>>/versioneer.py", line 1413, in get_versions cfg = get_config_from_root(root) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/<<PKGBUILDDIR>>/versioneer.py", line 343, in get_config_from_root parser = configparser.SafeConfigParser() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'configparser' has no attribute 'SafeConfigParser'. Did you mean: 'RawConfigParser'? This patch follows [Python 3.12 configparser porting guidelines] to resolve this issue. [Debian bug #1058220]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058220 [Python 3.12 configparser porting guidelines]: https://docs.python.org/3/whatsnew/3.12.html#configparser Signed-off-by: Étienne Mollier <emollier@debian.org>
|
Thanks for this PR @emollier. We are going to address this across all of our packages (planned for the 2024.10 release of QIIME 2) in one pass, so I'm going to close. |
|
Makes sense, thanks for the status! :)
|
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen first in Debian bug #1058220, execution of the versioneer.py script fails with Python 3.12 with the following error:
This patch follows Python 3.12 configparser porting guidelines to resolve this issue.